Repository navigation
fix(laya-ts): end batch request contexts in reverse start order - #1339
Merged
Merged
Conversation
Every per-request context of a checkpoint group starts before any of them ends, so the end hooks must unwind LIFO: a hook that opens something in start and closes it in end (a tracing span, an AsyncLocalStorage frame, an in-flight counter) otherwise closes the wrong frame, and every request after the first inherits a corrupted context. Python's Router.predict_batch ends its contexts in reverse and its docstring states the reason; this runtime ended them in start order. The three tests that asserted the forward order now assert the reverse one (including a three-request case, which is the smallest shape where the rule is visible rather than merely different); before the change six order assertions fail.
NandhaKishorM
added a commit
that referenced
this pull request
Oct 24, 2026
33 PRs. Server hardening (#1331, #1332, #1333), TypeScript parity (#1330, #1336, #1337, #1338, #1339, #1340, #1341, #1342, #1343), fail-closed input handling in evals and the integrations (#1317, #1318, #1319, #1320, #1321, #1322, #1326, #1335), exact and faster script detection (#1334, #1349), JVM and .NET resource handling (#1327, #1328, #1329, #1346), port goldens and clipping (#1324 excluded, #1325, #1344, #1345), CI (#1323, #1347, #1348). Verified before tagging: all 92 suites pass, 610 tests. ruff clean on both lists. laya-ts 1247 tests across 44 files, tsc --noEmit clean. Version agrees across pyproject.toml, laya.__version__ and nix/package.nix. README carries 0.4.15 only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Router._endContextsdispatchesonPredictEndin reverse start order (elapsed/usage stamping stays forward).Why
Every per-request context of a checkpoint group starts before any of them ends, so the ends must unwind LIFO: a hook that opens in start and closes in end (a tracing span, an
AsyncLocalStorageframe, an in-flight counter) otherwise closes the wrong frame, and every request after the first inherits a corrupted context. Python'sRouter.predict_batchends its contexts in reverse and its docstring states the reason.How it was verified
Checklist
main(branch cut fromupstream/mainat 0.4.14)